Fix trackball click: I2S MCLK was claiming GPIO0; emulator pin-ownership parity
Root cause (on device): sound_engine zero-initialized i2s_pin_config_t, leaving mck_io_num == 0. i2s_set_pin() then claimed GPIO0 — an MCLK-capable pin on the S3 and the trackball centre / BOOT line — as its MCLK output. Verified on device with a diagnostic build: pin0 read LOW at idle, exactly one latched FALLING edge, clicks never registered. - sound_engine: set pins.mck_io_num = I2S_PIN_NO_CHANGE explicitly. - NetDeck: register the trackball click on release with contact-bounce collapse (the proven CrtTerminal pattern); pollTouch re-arms when isPressed() stays true but getPoint() reports no points (stuck GT911 IRQ on some units). - Emulator parity (so this class of bug dies before flashing): GPIO-matrix pin-ownership model in the shim — i2s_set_pin() claims its pins, claimed pins are dead inputs (digitalRead LOW, no edges, loud WARNING on claim/ISR collisions); host pin writes go through emu::setPin/togglePin with an edge-accurate ISR latch (a full press+release pulse between dispatches no longer gets swallowed); E2E inits SDL_INIT_AUDIO so the I2S path actually runs there. Regression coverage: e2e/trackball_click (fails on the old engine), unit/shim_claimed_pin_is_dead_input, unit/shim_edge_survives_same_dispatch_pulse. - Makefile: firmware step follows the sketch move (root platformio.ini, src_dir = src/netdeck). - HW.md: new notes file for emulator-vs-hardware quirks and the on-device debugging recipe. On-device verified: clicks register in both views (beacon drops, node routing). Fast layer 23 unit + 7 integration green. Note: e2e boot_and_controls + network_journey failures are pre-existing at HEAD (reproduced on a clean stash before this change).
This commit is contained in:
@@ -188,3 +188,17 @@ E2E freeze-tint pixel assertions were stale since the diagonal-stripe
|
||||
rework (pre-existing failures at HEAD under SDL2 too) — updated to the
|
||||
committed pattern, sampled away from the freeze text. Full suite green:
|
||||
14 unit + 7 integration + 3 E2E journeys, 0 failures.
|
||||
|
||||
### Hardware fix: trackball click dead on device (fixed this commit)
|
||||
|
||||
The sound engine zero-initialized `i2s_pin_config_t`, leaving
|
||||
`mck_io_num == 0`; `i2s_set_pin()` then claimed **GPIO0** — an
|
||||
MCLK-capable pin on the S3 and the trackball centre / BOOT line — as
|
||||
its MCLK output, so clicks never registered on hardware (verified with
|
||||
an on-device diagnostic build: `pin0=0` at idle, one latched FALLING
|
||||
edge). Fix: `pins.mck_io_num = I2S_PIN_NO_CHANGE` in
|
||||
`sound_engine.cpp`; the click now also registers on release with
|
||||
contact-bounce collapse (the proven `CrtTerminal` pattern). The
|
||||
emulator gained a GPIO-matrix pin-ownership model + edge-accurate ISR
|
||||
latch so this class of bug reproduces there (`e2e/trackball_click`
|
||||
fails on the old code, passes on the fix) — see [HW.md](HW.md).
|
||||
|
||||
Reference in New Issue
Block a user