You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

CONTRIBUTING.md 6.1 KiB

4 years ago
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172
  1. # Contributing to Homepage
  2. Looking to contribute something to Homepage? **Here's how you can help.**
  3. Please take a moment to review this document in order to make the contribution
  4. process easy and effective for everyone involved.
  5. Following these guidelines helps to communicate that you respect the time of
  6. the developers managing and developing this open source project. In return,
  7. they should reciprocate that respect in addressing your issue or assessing
  8. patches and features.
  9. ## Using the issue tracker
  10. The [issue tracker](https://github.com/thetomester13/homepage/issues) is
  11. the preferred channel for [bug reports](#bug-reports), [features requests](#feature-requests)
  12. and [submitting pull requests](#pull-requests), but please respect the following
  13. restrictions:
  14. * Please **do not** derail or troll issues. Keep the discussion on topic and
  15. respect the opinions of others.
  16. ## Issues and labels
  17. Our bug tracker utilizes several labels to help organize and identify issues. Here's what they represent and how we use them:
  18. - `bug` - Issues for a potential bug in Homepage.
  19. - `docs` - Issues for improving or updating our documentation.
  20. - `feature` - Issues asking for a new feature to be added, or an existing one to be extended or modified.
  21. - `help wanted` - Issues we need or would love help from the community to resolve.
  22. - `question` - General purpose question about Homepage.
  23. For a complete look at our labels, see the [project labels page](https://github.com/thetomester13/homepage/labels).
  24. ## Bug reports
  25. A bug is a _demonstrable problem_ that is caused by the code in the repository.
  26. Good bug reports are extremely helpful, so thanks!
  27. Guidelines for bug reports:
  28. 0. **Validate and lint your code** — [validate your HTML](http://html5.validator.nu)
  29. and [lint your HTML](https://github.com/twbs/bootlint) to ensure your
  30. problem isn't caused by a simple error in your own code.
  31. 1. **Use the GitHub issue search** — check if the issue has already been
  32. reported.
  33. 2. **Check if the issue has been fixed** — try to reproduce it using the
  34. latest `master` or development branch in the repository.
  35. 3. **Isolate the problem** — ideally create a live example.
  36. [This jsfiddle](http://jsfiddle.net/) is a helpful tools.
  37. A good bug report shouldn't leave others needing to chase you up for more
  38. information. Please try to be as detailed as possible in your report. What is
  39. your environment? What steps will reproduce the issue? What browser(s) and OS
  40. experience the problem? Do other browsers show the bug differently? What
  41. would you expect to be the outcome? All these details will help people to fix
  42. any potential bugs.
  43. Example:
  44. > Short and descriptive example bug report title
  45. >
  46. > A summary of the issue and the browser/OS environment in which it occurs. If
  47. > suitable, include the steps required to reproduce the bug.
  48. >
  49. > 1. This is the first step
  50. > 2. This is the second step
  51. > 3. Further steps, etc.
  52. >
  53. > `<url>` - a link to the reduced test case
  54. >
  55. > Any other information you want to share that is relevant to the issue being
  56. > reported. This might include the lines of code that you have identified as
  57. > causing the bug, and potential solutions (and your opinions on their
  58. > merits).
  59. ## Feature requests
  60. Feature requests are welcome. But take a moment to find out whether your idea
  61. fits with the scope and aims of the project. It's up to *you* to make a strong
  62. case to convince the project's developers of the merits of this feature. Please
  63. provide as much detail and context as possible.
  64. ## Pull requests
  65. Good pull requests—patches, improvements, new features—are a fantastic
  66. help. They should remain focused in scope and avoid containing unrelated
  67. commits.
  68. **Please ask first** before embarking on any significant pull request (e.g.
  69. implementing features, refactoring code, porting to a different language),
  70. otherwise you risk spending a lot of time working on something that the
  71. project's developers might not want to merge into the project.
  72. Please adhere to the [coding guidelines](#code-guidelines) used throughout the
  73. project (indentation, accurate comments, etc.) and any other requirements
  74. (such as test coverage).
  75. Adhering to the following process is the best way to get your work
  76. included in the project:
  77. 1. [Fork](https://help.github.com/articles/fork-a-repo/) the project, clone your fork,
  78. and configure the remotes:
  79. ```bash
  80. # Clone your fork of the repo into the current directory
  81. git clone https://github.com/<your-username>/homepage.git
  82. # Navigate to the newly cloned directory
  83. cd homepage
  84. # Assign the original repo to a remote called "upstream"
  85. git remote add upstream https://github.com/thetomester13/homepage.git
  86. ```
  87. 2. If you cloned a while ago, get the latest changes from upstream:
  88. ```bash
  89. git checkout master
  90. git pull upstream master
  91. ```
  92. 3. Create a new topic branch (off the main project development branch) to
  93. contain your feature, change, or fix:
  94. ```bash
  95. git checkout -b <topic-branch-name>
  96. ```
  97. 4. Commit your changes in logical chunks. Please adhere to these [git commit
  98. message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
  99. or your code is unlikely be merged into the main project. Use Git's
  100. [interactive rebase](https://help.github.com/articles/about-git-rebase/)
  101. feature to tidy up your commits before making them public.
  102. 5. Locally merge (or rebase) the upstream development branch into your topic branch:
  103. ```bash
  104. git pull [--rebase] upstream master
  105. ```
  106. 6. Push your topic branch up to your fork:
  107. ```bash
  108. git push origin <topic-branch-name>
  109. ```
  110. 7. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/)
  111. with a clear title and description against the `master` branch.
  112. **IMPORTANT**: By submitting a patch, you agree to allow the project owners to
  113. license your work under the terms of the [MIT License](LICENSE.md) (if it
  114. includes code changes).
  115. ## Code guidelines
  116. - Readability
  117. - Need semicolons
  118. - strict mode
  119. - "Attractive"
  120. ## License
  121. By contributing your code, you agree to license your contribution under the [MIT License](LICENSE.md).